fe1617ffea
Metal sounded like a good idea to get in the emulator but frankly I underestimated just how experimental and not ready it was. From my write up in the Discord: ``` As is, Metal supports only a few games. The games it does support freeze on first use of not playing them via Vulkan, because shader translation is broken. So you need to use a dirty hack to not delete all your shaders. Not to mention it breaks many games via MoltenVK because of changes to the shared GPU code. Merging Metal seemed like a great idea, because of the few games it does support. But I don't think it's worth it. Many of the games it breaks via MoltenVK *don't work via Metal*. Which effectively makes current Ryubing worse for Mac users than Ryujinx 1.1.1403. I think what I'm gonna do is revert Metal, and reopen it as a PR. That way, you can still take advantage of the Metal backend as is, but without making other games worse with no solution. ``` For what it's worth, the shader translation part could at least be "fixed" by always applying a 30ms delay for shader translation to Metal. That being said, that solution sucks ass. The MoltenVK regressions are even worse. I hope this is not a let down to the Mac users. I hope you realize I'm reverting this because you're actively getting a worse experience with it in the emulator.
106 lines
3.2 KiB
C#
106 lines
3.2 KiB
C#
using Avalonia;
|
|
using Avalonia.Controls;
|
|
using Avalonia.Media;
|
|
using Ryujinx.Ava.Utilities.Configuration;
|
|
using Ryujinx.Common;
|
|
using Ryujinx.Common.Configuration;
|
|
using Ryujinx.Common.Logging;
|
|
using System;
|
|
|
|
namespace Ryujinx.Ava.UI.Renderer
|
|
{
|
|
public class RendererHost : UserControl, IDisposable
|
|
{
|
|
public readonly EmbeddedWindow EmbeddedWindow;
|
|
|
|
public event EventHandler<EventArgs> WindowCreated;
|
|
public event Action<object, Size> BoundsChanged;
|
|
|
|
public RendererHost()
|
|
{
|
|
Focusable = true;
|
|
FlowDirection = FlowDirection.LeftToRight;
|
|
|
|
EmbeddedWindow = ConfigurationState.Instance.Graphics.GraphicsBackend.Value switch
|
|
{
|
|
GraphicsBackend.OpenGl => new EmbeddedWindowOpenGL(),
|
|
GraphicsBackend.Vulkan => new EmbeddedWindowVulkan(),
|
|
_ => throw new NotSupportedException()
|
|
};
|
|
|
|
Initialize();
|
|
}
|
|
|
|
public GraphicsBackend Backend =>
|
|
EmbeddedWindow switch
|
|
{
|
|
EmbeddedWindowVulkan => GraphicsBackend.Vulkan,
|
|
EmbeddedWindowOpenGL => GraphicsBackend.OpenGl,
|
|
_ => throw new NotImplementedException()
|
|
};
|
|
|
|
public RendererHost(string titleId)
|
|
{
|
|
Focusable = true;
|
|
FlowDirection = FlowDirection.LeftToRight;
|
|
|
|
EmbeddedWindow =
|
|
#pragma warning disable CS8524
|
|
ConfigurationState.Instance.Graphics.GraphicsBackend.Value switch
|
|
#pragma warning restore CS8524
|
|
{
|
|
GraphicsBackend.OpenGl => new EmbeddedWindowOpenGL(),
|
|
GraphicsBackend.Vulkan => new EmbeddedWindowVulkan(),
|
|
};
|
|
|
|
string backendText = EmbeddedWindow switch
|
|
{
|
|
EmbeddedWindowVulkan => "Vulkan",
|
|
EmbeddedWindowOpenGL => "OpenGL",
|
|
_ => throw new NotImplementedException()
|
|
};
|
|
|
|
Logger.Info?.PrintMsg(LogClass.Gpu, $"Backend ({ConfigurationState.Instance.Graphics.GraphicsBackend.Value}): {backendText}");
|
|
|
|
Initialize();
|
|
}
|
|
|
|
|
|
private void Initialize()
|
|
{
|
|
EmbeddedWindow.WindowCreated += CurrentWindow_WindowCreated;
|
|
EmbeddedWindow.BoundsChanged += CurrentWindow_BoundsChanged;
|
|
|
|
Content = EmbeddedWindow;
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
if (EmbeddedWindow != null)
|
|
{
|
|
EmbeddedWindow.WindowCreated -= CurrentWindow_WindowCreated;
|
|
EmbeddedWindow.BoundsChanged -= CurrentWindow_BoundsChanged;
|
|
}
|
|
|
|
GC.SuppressFinalize(this);
|
|
}
|
|
|
|
protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
|
|
{
|
|
base.OnDetachedFromVisualTree(e);
|
|
|
|
Dispose();
|
|
}
|
|
|
|
private void CurrentWindow_BoundsChanged(object sender, Size e)
|
|
{
|
|
BoundsChanged?.Invoke(sender, e);
|
|
}
|
|
|
|
private void CurrentWindow_WindowCreated(object sender, nint e)
|
|
{
|
|
WindowCreated?.Invoke(this, EventArgs.Empty);
|
|
}
|
|
}
|
|
}
|